Skip to content

fix: restore user service account management#106

Merged
cxymds merged 1 commit intomainfrom
codex/fix-user-service-account-issue-105
Apr 24, 2026
Merged

fix: restore user service account management#106
cxymds merged 1 commit intomainfrom
codex/fix-user-service-account-issue-105

Conversation

@cxymds
Copy link
Copy Markdown
Member

@cxymds cxymds commented Apr 24, 2026

Pull Request

Description

Restore user-scoped AK/SK management in the user edit dialog and fix the API usage so it matches the RustFS admin backend.

This PR:

  • restores the Access Keys tab in the user edit dialog
  • removes pagination inside that tab and enlarges the dialog
  • fixes user-scoped service account calls to use the shared admin endpoints
  • adds focused regression tests for tab availability, pagination config, and user service-account request building

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
node --experimental-strip-types --test tests/lib/user-edit-tabs.test.ts tests/lib/data-table-pagination.test.ts tests/lib/user-service-account-api.test.ts
pnpm tsc --noEmit
pnpm lint
pnpm prettier --check app/'(dashboard)'/access-keys/page.tsx components/user/edit-form.tsx components/user/notice.tsx components/user/edit/access-keys.tsx hooks/use-data-table.tsx hooks/use-policies.ts hooks/use-users.ts lib/data-table-pagination.ts lib/data-table-pagination.js lib/user-edit-tabs.ts lib/user-edit-tabs.js lib/user-service-account-api.ts lib/user-service-account-api.js tests/lib/data-table-pagination.test.ts tests/lib/user-edit-tabs.test.ts tests/lib/user-service-account-api.test.ts

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Closes #105

Screenshots (if applicable)

Not included.

Additional Notes

pnpm lint still reports one pre-existing warning in components/object/preview-modal.tsx about using <img>, but it does not block the command.

@cxymds cxymds merged commit ff71a89 into main Apr 24, 2026
11 checks passed
@cxymds cxymds deleted the codex/fix-user-service-account-issue-105 branch April 24, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can no longer create AK/SK for a user in the user edit form

1 participant